This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Add target existence checks to Unwind find module#518
Merged
sergiud merged 3 commits intogoogle:masterfrom Jan 17, 2020
MichaelDarr:MichaelDarr/unwind-target-checks
Merged
Add target existence checks to Unwind find module#518sergiud merged 3 commits intogoogle:masterfrom MichaelDarr:MichaelDarr/unwind-target-checks
sergiud merged 3 commits intogoogle:masterfrom
MichaelDarr:MichaelDarr/unwind-target-checks
Conversation
The build systems of projects depending on Glog may call the Unwind find module multiple times. In these cases, the current unwind find module tries to create a duplicate unwind::unwind target, crashing the build. This patch adds an existence check before target creation to fix this issue. Signed-off-by: Michael Darr <mdarr@matician.com>
sergiud
reviewed
Jan 17, 2020
Signed-off-by: Michael Darr <medarr@email.wm.edu>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build systems of projects depending on Glog may call the Unwind find
module multiple times. In these cases, the current unwind find module tries
to create a duplicate unwind::unwind target, crashing the build. This
patch adds an existence check before target creation to fix this issue.
Signed-off-by: Michael Darr mdarr@matician.com