This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Conversation
Since there is no config_setting for Linux (bazelbuild/bazel#11107), Linux needs to be the default case.
|
Seems like this is only fixed for Bazel but not CMake. I have a CMake project and while compiling I got the error that syscall is not declared: |
attilaolah
reviewed
Sep 25, 2020
| # Config setting for WebAssembly target. | ||
| native.config_setting( | ||
| name = "wasm", | ||
| values = {"cpu": "wasm"}, |
There was a problem hiding this comment.
Shortly before this code was submitted, wasm32 and wasm64 were added in bazelbuild/platforms@966defd as standard WebAssembly CPU architectures: BUILD#L83-91.
Maybe this should be changed accordingly (i.e. split into two config settings, and list them both in the select below).
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Bazel build configuration assumes that <sys/syscall.h> is present on non-windows targets, which is not the case when building with emscripten. This PR fixes the issue.