This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Move win #define sleep out of #ifdef _MSC_VER#721
Closed
rubensf wants to merge 1 commit intogoogle:masterfrom
rubensf:sleep
Closed
Move win #define sleep out of #ifdef _MSC_VER#721rubensf wants to merge 1 commit intogoogle:masterfrom rubensf:sleep
#define sleep out of #ifdef _MSC_VER#721rubensf wants to merge 1 commit intogoogle:masterfrom
rubensf:sleep
Conversation
sleep (with lowercase 's') is also not defined on MinGW GCC, so we have to define it even when not using MSVC.
Contributor
|
I'm wondering why the CI did not catch this problem? |
Author
|
Ah, this was my bad. I'm using glog @ Somehow I can't find the correct Thanks for the comment! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sleep (with lowercase 's') is also not defined on MinGW GCC,
so we have to define it even when not using MSVC.