This repository was archived by the owner on Jun 30, 2025. It is now read-only.
libglog.pc: Set Libs.private for static linking#787
Merged
sergiud merged 1 commit intogoogle:masterfrom Jan 25, 2022
Arfrever:libglog.pc_private_libs
Merged
libglog.pc: Set Libs.private for static linking#787sergiud merged 1 commit intogoogle:masterfrom Arfrever:libglog.pc_private_libs
sergiud merged 1 commit intogoogle:masterfrom
Arfrever:libglog.pc_private_libs
Conversation
sergiud
suggested changes
Jan 25, 2022
Contributor
sergiud
left a comment
There was a problem hiding this comment.
LGTM. Only some nitpicks.
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
=======================================
Coverage 72.72% 72.72%
=======================================
Files 17 17
Lines 3256 3256
=======================================
Hits 2368 2368
Misses 888 888 Continue to review full report at Codecov.
|
sergiud
approved these changes
Jan 25, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements suggestion from #57.
Before:
After:
By the way, I was also trying
get_target_property(some_output_variable glog LINK_LIBRARIES), but it provides raw cmake-style value such asunwind::unwind;-lpthread;gflagswhich would need complicated parsing and transformation, so the solution used in this pull request seems easier.