Missing `SponsorshipEvent` in events types

[jpmcb]

There appears to be a new event type, the SponsorshipEvent as defined by the GitHub docs:

https://docs.github.com/en/rest/overview/github-event-types?apiVersion=2022-11-28#sponsorshipevent

This doesn't seem to be implemented:

undefined: github.SponsorshipEvent

and I don't see it in event_types.go: https://github.com/google/go-github/blob/master/github/event_types.go

I'd be happy to pick this up 👍🏼

[gmlewis]

That sounds great. Thank you, @jpmcb !
It's yours. Please see our CONTRIBUTING.md guide, as it has recently changed a fair amount.

[DiegoDev2]

@gmlewis Shouldn't this issue be closed already?

[gmlewis]

@gmlewis Shouldn't this issue be closed already?

@CodeDiego15 - why do you say that?
SponsorshipEvent still seems to be missing from the code as far as I can tell. Agreed?

[DiegoDev2]

@gmlewis well, I understood that SponsorshipEvent is not used, and that I would have to remove it something like that? and excuse me if you don't.

[gmlewis]

@gmlewis well, I understood that SponsorshipEvent is not used, and that I would have to remove it something like that? and excuse me if you don't.

I'm sorry, I must be confused. Do you have more context to this topic than just this one issue, because that is all I'm basing my question upon.

[DiegoDev2]

@gmlewis well, I understood that SponsorshipEvent is not used, and that I would have to remove it something like that? and excuse me if you don't.

Sorry, I don't have any more information on the topic, I was just looking for a topic to collaborate with and I went into this one and saw that it was simple and I checked the code and realized that SponsorshipEvent wasn't there. We can verify the code. https://github.com/google/go-github/blob/master/github/event_types.go

[gmlewis]

OK, in that case, I mis-interpreted your original question.

This issue remains open because it indeed has not been implemented yet.

I think it is safe to say that @jpmcb is not planning on working on it afterall, but let's give @jpmcb one day to respond.
If there is no response, then we can assign the issue to you, @CodeDiego15 .

[DiegoDev2]

OK, in that case, I mis-interpreted your original question.

This issue remains open because it indeed has not been implemented yet.

I think it is safe to say that @jpmcb is not planning on working on it afterall, but let's give @jpmcb one day to respond. If there is no response, then we can assign the issue to you, @CodeDiego15 .

Ok I think it's perfect I have no problem working on it, if you assign me the problem would you give me more details about it?

[DiegoDev2]

@gmlewis I was reviewing the code, if I do a PR you have to include the tests also in: https://github.com/google/go-github/blob/master/github/event_types_test.go ??

[DiegoDev2]

OK, in that case, I mis-interpreted your original question.

This issue remains open because it indeed has not been implemented yet.

I think it is safe to say that @jpmcb is not planning on working on it afterall, but let's give @jpmcb one day to respond. If there is no response, then we can assign the issue to you, @CodeDiego15 .

Hello, sorry the time it's a bit late, but I'm done implementing 'SponsorshipEvent', do the pr?

[gmlewis]

Hello, sorry the time it's a bit late, but I'm done implementing 'SponsorshipEvent', do the pr?

OK, sounds good to me. It's yours. Thank you, @CodeDiego15.

[gmlewis]

@gmlewis I was reviewing the code, if I do a PR you have to include the tests also in: https://github.com/google/go-github/blob/master/github/event_types_test.go ??

Yes, please include tests similar to what we already have. We like to keep this repo heavily tested. Thank you.