Update ListRepositoryWorkflowRuns to support all query parameters#1498
Merged
gmlewis merged 1 commit intogoogle:masterfrom Apr 20, 2020
Merged
Update ListRepositoryWorkflowRuns to support all query parameters#1498gmlewis merged 1 commit intogoogle:masterfrom
gmlewis merged 1 commit intogoogle:masterfrom
Conversation
googlebot
added
the
cla: yes
closes google#1497 - update the method to use the more specific ListWorkflowRunsOptions struct
Codecov Report
@@ Coverage Diff @@
## master #1498 +/- ##
=======================================
Coverage 68.19% 68.19%
=======================================
Files 94 94
Lines 8452 8452
=======================================
Hits 5764 5764
Misses 1819 1819
Partials 869 869
Continue to review full report at Codecov.
|
gmlewis
approved these changes
Apr 20, 2020
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
LGTM.
Note that this is a breaking change, but we now make releases on an as-needed basis.
So the next time we release, we will need to bump the version to v32.
Awaiting second LGTM before merging.
Collaborator
|
Thank you, @wesleimp! |
gmlewis
added
the
Breaking API Change
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
This was referenced May 28, 2021
Closed
This was referenced Jun 6, 2021
This was referenced Jun 21, 2021
Closed
This was referenced Jun 30, 2021
This was referenced Jul 9, 2021
Closed
This was referenced Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1497
Let me know if I need to update any of the tests as well - I looked through the existing tests and didn't see any that were specifically testing the unique query params of workflow endpoints.