Fix: Remove Sort & Direction Fields From IssueListCommentsOptions#1584
Merged
gmlewis merged 1 commit intogoogle:masterfrom Aug 10, 2020
Merged
Fix: Remove Sort & Direction Fields From IssueListCommentsOptions#1584gmlewis merged 1 commit intogoogle:masterfrom
gmlewis merged 1 commit intogoogle:masterfrom
Conversation
- The `Sort` & `Direction` fields in` IssueListCommentsOptions` were removed from the github api so they no longer work. - Fields have been removed from the struct and any corresponding tests > These are tagged as breaking changes
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1584 +/- ##
=======================================
Coverage 67.95% 67.95%
=======================================
Files 96 96
Lines 8762 8762
=======================================
Hits 5954 5954
Misses 1898 1898
Partials 910 910
Continue to review full report at Codecov.
|
gmlewis
added
the
Breaking API Change
Collaborator
|
Thank you, @nightlark ! |
Collaborator
|
Unfortunately, this PR removed fields that are still being used, as the original request #1583 reported the Reverting PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: #1583
The
Sort&Directionfields inIssueListCommentsOptionswere removed from the github api so they no longer work.Fields have been removed from the struct and any corresponding tests.
tests pass
code fmt