Handle 'since' in addition to 'page' for pagination response

[brianlangdon]

pagination may return either 'page' or 'since' in the header. 'since' was not being handled

Fixes: #2112.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[brianlangdon]

@googlebot I signed it!

[codecov]

Codecov Report

Merging #2135 (8825238) into master (b26fa8f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2135   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files         112      112           
  Lines       10036    10041    +5     
=======================================
+ Hits         9815     9820    +5     
  Misses        154      154           
  Partials       67       67           

Impacted Files	Coverage Δ
github/github.go	97.62% <100.00%> (+0.02%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26fa8f...8825238. Read the comment docs.

[gmlewis]

Thank you, @brianlangdon !
LGTM.

Awaiting second LGTM before merging.

[brianlangdon]

I've cleared the conflict introduced by PR #2154 would it be possible for somebody to approve and merge? @gmlewis , @wesleimp ?

[gmlewis]

I've cleared the conflict introduced by PR #2154 would it be possible for somebody to approve and merge? @gmlewis , @wesleimp ?

Thank you, @brianlangdon - can you please run go fmt on your file and push the changes?

[brianlangdon]

@gmlewis, changes pushed I hope!, Thanks

[gmlewis]

Thank you, @brianlangdon ! LGTM.

I've cleared the conflict introduced by PR #2154 would it be possible for somebody to approve and merge? @gmlewis , @wesleimp ?

Please note that ALL other contributors to this repo are welcome to provide the second PR review/comment/approval that we need for merging.

Perhaps @Parker77 has time today to review.

[Parker77]

LGTM.

[gmlewis]

LGTM.

Thank you, @Parker77 !
Merging.

[lonre]

Hi, @gmlewis @brianlangdon

It sees that this break https://docs.github.com/en/rest/reference/repos#list-commits with since params

[gmlewis]

Hi, @gmlewis @brianlangdon

It sees that this break https://docs.github.com/en/rest/reference/repos#list-commits with since params

Hi @lonre - could you please be more specific?

How did it break?

Can you please give an example of the response (before and after, or "working" and "broken")?

[lonre]

Hi @gmlewis

with https://api.github.com/repos/Homebrew/homebrew-cask/commits?since=2021-12-04T10%3A43%3A42Z request,

the response NextPage and LastPage is 0, the pagination is broken

[gmlewis]

Thank you for more details, @lonre !
I'll re-open #2112 and show my findings there.