Skip to content

Change StorageBilling.EstimatedPaidStorageForMonth from int to float64 #2205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 1 commit into from
Nov 15, 2021
Merged

Change StorageBilling.EstimatedPaidStorageForMonth from int to float64 #2205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions github/billing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ type PackageBilling struct {

// StorageBilling represents a GitHub Storage billing.
type StorageBilling struct {
DaysLeftInBillingCycle int `json:"days_left_in_billing_cycle"`
EstimatedPaidStorageForMonth int `json:"estimated_paid_storage_for_month"`
EstimatedStorageForMonth int `json:"estimated_storage_for_month"`
DaysLeftInBillingCycle int `json:"days_left_in_billing_cycle"`
EstimatedPaidStorageForMonth float64 `json:"estimated_paid_storage_for_month"`
EstimatedStorageForMonth int `json:"estimated_storage_for_month"`
}

// GetActionsBillingOrg returns the summary of the free and paid GitHub Actions minutes used for an Org.
Expand Down
8 changes: 4 additions & 4 deletions github/billing_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func TestBillingService_GetStorageBillingOrg(t *testing.T) {
testMethod(t, r, "GET")
fmt.Fprint(w, `{
"days_left_in_billing_cycle": 20,
"estimated_paid_storage_for_month": 15,
"estimated_paid_storage_for_month": 15.25,
"estimated_storage_for_month": 40
}`)
})
Expand All @@ -133,7 +133,7 @@ func TestBillingService_GetStorageBillingOrg(t *testing.T) {

want := &StorageBilling{
DaysLeftInBillingCycle: 20,
EstimatedPaidStorageForMonth: 15,
EstimatedPaidStorageForMonth: 15.25,
EstimatedStorageForMonth: 40,
}
if !cmp.Equal(hook, want) {
Expand Down Expand Up @@ -262,7 +262,7 @@ func TestBillingService_GetStorageBillingUser(t *testing.T) {
testMethod(t, r, "GET")
fmt.Fprint(w, `{
"days_left_in_billing_cycle": 20,
"estimated_paid_storage_for_month": 15,
"estimated_paid_storage_for_month": 15.25,
"estimated_storage_for_month": 40
}`)
})
Expand All @@ -275,7 +275,7 @@ func TestBillingService_GetStorageBillingUser(t *testing.T) {

want := &StorageBilling{
DaysLeftInBillingCycle: 20,
EstimatedPaidStorageForMonth: 15,
EstimatedPaidStorageForMonth: 15.25,
EstimatedStorageForMonth: 40,
}
if !cmp.Equal(hook, want) {
Expand Down