Add missing attribute job_runs in WorkflowRunBill#2206
Merged
gmlewis merged 2 commits intogoogle:masterfrom Nov 18, 2021
Merged
Add missing attribute job_runs in WorkflowRunBill#2206gmlewis merged 2 commits intogoogle:masterfrom
gmlewis merged 2 commits intogoogle:masterfrom
Conversation
google-cla
Bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2206 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 112 112
Lines 10036 10036
=======================================
Hits 9815 9815
Misses 154 154
Partials 67 67
Continue to review full report at Codecov.
|
gmlewis
approved these changes
Nov 18, 2021
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @marcelocarlos !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Update
WorkflowRunBillto include a missing attributeWhat this PR does / why we need it
Brings the implementation inline with the expected API response (docs here).
WorkflowRunBillcurrent implementation is missing the JobRuns (job_runs) attribute. This is important when calculating the actual cost and time spent in a given workflow run as thetotal_msdoesn't include the rounding ups or multipliers that GitHub applied to each job run.