Clean up method return consistency#2318
Merged
gmlewis merged 11 commits intogoogle:masterfrom Mar 25, 2022
Merged
Conversation
Collaborator
Author
|
According to https://githubstatus.com , actions are currently experiencing degraded performance, which is why no tests have run as of yet. |
Codecov Report
@@ Coverage Diff @@
## master #2318 +/- ##
==========================================
+ Coverage 97.95% 98.04% +0.09%
==========================================
Files 117 117
Lines 10402 10460 +58
==========================================
+ Hits 10189 10256 +67
+ Misses 146 140 -6
+ Partials 67 64 -3
Continue to review full report at Codecov.
|
Collaborator
Author
|
@Parker77 - do you have time for a code review? |
Collaborator
Author
|
Thank you, @Parker77 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@h2floh pointed out in #2315 that our method returns are inconsistent.
This PR addresses this inconsistency.
@h2floh - please review and LGTM+Approve this PR if you agree to the changes.