Add support to list custom roles for organizations#2336
Add support to list custom roles for organizations#2336gmlewis merged 4 commits intogoogle:masterfrom
Conversation
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @tamboliasir1 !
Let's please change some of the naming and update the comments.
|
Please also make sure to run |
|
Hi @gmlewis I have made changes and pushed commit. Can you please review? Thank you so much. |
Codecov Report
@@ Coverage Diff @@
## master #2336 +/- ##
=======================================
Coverage 98.04% 98.05%
=======================================
Files 118 119 +1
Lines 10458 10471 +13
=======================================
+ Hits 10254 10267 +13
Misses 140 140
Partials 64 64
Continue to review full report at Codecov.
|
gmlewis
left a comment
There was a problem hiding this comment.
Sorry, I was wrong.
After you fix the URL in the comments, LGTM.
We will then be ready for a second LGTM+Approval from any other contributor to this repo before merging.
|
HI @reedloden @gmlewis Sorry for this silly typo I have resolved it please review. Please let me know if there is anything. Thank you. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @tamboliasir1 !
And thank you, @reedloden for catching the typos!
LGTM.
Awaiting second LGTM from any other contributor to this repo before merging.
joshua-hancox
left a comment
There was a problem hiding this comment.
LGTM (Not a previous contributor though, just an interested party 😄 )
Thank you, @joshuahancox ! Merging. |
|
Thank you @gmlewis. Would love to contribute more!!😄 |
|
@gmlewis can we get a release of |
I will work on getting a release out before Saturday. |
@reedloden - https://github.com/google/go-github/releases/tag/v44.0.0 is now available that contains this PR. |
@gmlewis woot woot. Thank you so much! |
Fixes: #2327 .
Thanks for this opportunity.