commit with obvious gofmt issue#2348
Conversation
|
@gmlewis well this one failed: https://github.com/google/go-github/runs/6220310903?check_suite_focus=true weird. |
Codecov Report
@@ Coverage Diff @@
## master #2348 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 119 119
Lines 10471 10471
=======================================
Hits 10267 10267
Misses 140 140
Partials 64 64
Continue to review full report at Codecov.
|
|
Ah, I think I found it.... it's because the example directory is its own go module. I don't think golangci-lint will descent into other modules. cd'ing into the examples directory and then running golangci-lint there correctly identifies the issue. So we'll need to change our actions workflow to manually run on examples and scrape and any other separate modules we have. Gotta run for now, but I can take a look at that later. |
No description provided.