run golangci-lint on all modules#2350
Merged
willnorris merged 3 commits intogoogle:masterfrom Apr 29, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2350 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 119 119
Lines 10471 10471
=======================================
Hits 10267 10267
Misses 140 140
Partials 64 64 Continue to review full report at Codecov.
|
willnorris
force-pushed
the
golanglint
branch
10 times, most recently
from
31e094f to
7a6069b
Compare
update go.sum for newreposecretwithlibsodium remove go modules for newreposecretwithxcrypto, since it's unnecessary
Collaborator
Author
|
I don't love that this now expands out to four linter runs for every PR, but it's the cleanest approach I think and they run super fast. |
gmlewis
approved these changes
Apr 29, 2022
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @willnorris !
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2349