Add ListExternalGroupsForTeamBySlug to Teams API#2674
Merged
gmlewis merged 1 commit intogoogle:masterfrom Mar 6, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2674 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 131 131
Lines 11442 11455 +13
=======================================
+ Hits 11219 11232 +13
Misses 152 152
Partials 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
valbeat
approved these changes
Feb 28, 2023
Contributor
Author
|
@gmlewis good to merge now? |
Collaborator
|
Thank you, @valbeat ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2217 added support for the majority of the External Groups API but omitted listing groups for a specific Team within an Organization.
This PR adds the missing method, and corrects the comment on the original
ListExternalGroupsmethod as that actually returns all external groups within the Organization. I added theForTeamBySlugsuffix based on other methods in the source to distinguish it from the original method.I've added tests based on the original
ListExternalGroupsmethod and everything passes.