Add fields to Branch Protection endpoint#2744
Merged
gmlewis merged 3 commits intogoogle:masterfrom Apr 9, 2023
yardenshoham:issues/2719
Merged
Add fields to Branch Protection endpoint#2744gmlewis merged 3 commits intogoogle:masterfrom yardenshoham:issues/2719
Branch Protection endpoint#2744gmlewis merged 3 commits intogoogle:masterfrom
yardenshoham:issues/2719
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2744 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 132 132
Lines 11611 11611
=======================================
Hits 11385 11385
Misses 154 154
Partials 72 72
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gmlewis
requested changes
Apr 9, 2023
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @yardenshoham.
Please correct the issues below and make sure to re-run gofmt and go generate ./... and push (not force-push since we always squash and merge PRs in this repo) the changes to this PR.
Contributor
Author
|
Thanks, changes applied |
…URL` instead of `Url`
gmlewis
reviewed
Apr 9, 2023
gmlewis
approved these changes
Apr 9, 2023
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @yardenshoham !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2719
This adds a few fields that were requested in #2719.