Add InstallationsCount to App

[chmouel]

It's not in the official github documentation yet but exposed to the API.

% curl -s -H "Accept: application/vnd.github.v3+json" -H "Authorization: Bearer $T" https://api.github.com/app|grep installations_count
  "installations_count": 3

[gmlewis]

Thank you, @chmouel .
Please run go generate ./... at the top of the repo and push the results to this PR.
See CONTRIBUTING.md for more details.

[gmlewis]

Please see the other change I asked for above and also please make sure all unit tests pass before pushing (not force-pushing since we always squash-and-merge in this repo) changes to the PR.

[chmouel]

@gmlewis apologies for the noise, i kinda messed my pr!

[gmlewis]

@gmlewis apologies for the noise, i kinda messed my pr!

No problem, @chmouel ! There's no rush... please feel free to take as long as you wish.

[chmouel]

I am not really sure why it fails on CI as it works locally

% go clean -testcache
% go generate github.com/google/go-github/..
% go test github.com/google/go-github/...
?   	github.com/google/go-github/v51/test/fields	[no test files]
?   	github.com/google/go-github/v51/test/integration	[no test files]
ok  	github.com/google/go-github/v51/github	0.898s

is it because i am using go 1.20 ?

[chmouel]

ah it works better with go generate -x should we maybe update CONTRIBUTING.md ? or maybe was there any other caching somewhere on my system, because -x is only supposed to print...

[codecov]

Codecov Report

Merging #2765 (9d5f093) into master (693ddff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2765   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         132      132           
  Lines       11638    11638           
=======================================
  Hits        11412    11412           
  Misses        154      154           
  Partials       72       72           

Impacted Files	Coverage Δ
github/apps.go	95.16% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[gmlewis]

ah it works better with go generate -x should we maybe update CONTRIBUTING.md ?

Feel free to clarify if you think that would be helpful.

[chmouel]

Feel free to clarify if you think that would be helpful.

I think it was not just my day today, and just was too quick without thinking much, apologies again for the noise, will be careful next time when contributing.

(I missed a dot to go generate github.com/google/go-github/.. 🤦🏻 )

[gmlewis]

No worries! Glad you got it all worked out. 😁

[gmlewis]

Thank you, @chmouel !
LGTM.
Merging.