Skip to content

Fix SecretScanning API by switching arguments from url to json #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jentfoo wants to merge 3 commits into from
Closed

Fix SecretScanning API by switching arguments from url to json #2871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7294f18
secret_scanning.go: API fix by switching arugments from url to json
jentfoo Aug 14, 2023
4812e1c
Apply PR feedback to make SecretScanningAlertListOptions params optional
jentfoo Aug 14, 2023
475c99b
`go generate` output
jentfoo Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 30 additions & 0 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions github/secret_scanning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,14 @@ type SecretScanningAlertLocationDetails struct {
// SecretScanningAlertListOptions specifies optional parameters to the SecretScanningService.ListAlertsForEnterprise method.
type SecretScanningAlertListOptions struct {
// State of the secret scanning alerts to list. Set to open or resolved to only list secret scanning alerts in a specific state.
State string `url:"state,omitempty"`
State *string `json:"state,omitempty"`

// A comma-separated list of secret types to return. By default all secret types are returned.
SecretType string `url:"secret_type,omitempty"`
SecretType *string `json:"secret_type,omitempty"`

// A comma-separated list of resolutions. Only secret scanning alerts with one of these resolutions are listed.
// Valid resolutions are false_positive, wont_fix, revoked, pattern_edited, pattern_deleted or used_in_tests.
Resolution string `url:"resolution,omitempty"`
Resolution *string `json:"resolution,omitempty"`

ListCursorOptions

Expand All @@ -77,14 +77,14 @@ type SecretScanningAlertListOptions struct {
type SecretScanningAlertUpdateOptions struct {
// Required. Sets the state of the secret scanning alert. Can be either open or resolved.
// You must provide resolution when you set the state to resolved.
State *string `url:"state,omitempty"`
State *string `json:"state,omitempty"`

// A comma-separated list of secret types to return. By default all secret types are returned.
SecretType *string `url:"secret_type,omitempty"`
SecretType *string `json:"secret_type,omitempty"`

// Required when the state is resolved. The reason for resolving the alert. Can be one of false_positive,
// wont_fix, revoked, or used_in_tests.
Resolution *string `url:"resolution,omitempty"`
Resolution *string `json:"resolution,omitempty"`
}

// Lists secret scanning alerts for eligible repositories in an enterprise, from newest to oldest.
Expand Down