Turn RequiredStatusChecks Checks and Contexts into pointers#3070
Turn RequiredStatusChecks Checks and Contexts into pointers#3070gmlewis merged 4 commits intogoogle:masterfrom emmahsax:remove-contexts-from-required-status-checks
RequiredStatusChecks Checks and Contexts into pointers#3070Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
RequiredStatusChecks Checks and Contexts into pointersRequiredStatusChecks Checks and Contexts into pointers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3070 +/- ##
==========================================
+ Coverage 97.72% 98.00% +0.27%
==========================================
Files 153 153
Lines 13390 10803 -2587
==========================================
- Hits 13085 10587 -2498
+ Misses 215 126 -89
Partials 90 90 ☔ View full report in Codecov by Sentry. |
|
Thank you, @valbeat ! |
|
Hi @gmlewis ! Could we get this released in a |
@ttomsu - this is now available in: https://github.com/google/go-github/releases/tag/v60.0.0 |
By making the both
ContextsandCheckspointers, the JSON will allow sending an empty slice as[]to the GitHub API, instead of taking those out and sendingnilornull.This will actually solve both #2976 and #2467.
I also clarified in the comments that empty slices are allowed, implying that if the user wants to set no checks or contexts, to allow passing an empty slice.
These changes allow the Go API to properly reflect the behavior of the GitHub API.