Allow querying rule set information by ID with information returned from GetRulesFromBranch#3089
Merged
gmlewis merged 1 commit intogoogle:masterfrom Mar 3, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3089 +/- ##
==========================================
- Coverage 97.72% 92.87% -4.86%
==========================================
Files 153 170 +17
Lines 13390 11403 -1987
==========================================
- Hits 13085 10590 -2495
- Misses 215 723 +508
Partials 90 90 ☔ View full report in Codecov by Sentry. |
tomfeigin
force-pushed
the
add-ruleset-id-to-repository-rule-object
branch
2 times, most recently
from
14c7bd5 to
232db8b
Compare
gmlewis
requested changes
Mar 3, 2024
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @tomfeigin !
One tweak for repo consistency, please.
You will also need to reformat after accepting the suggestion (or just change it locally yourself).
The purpose of this commit is to allow further querying of rulesets for a specific branch, at the organization or the repository level. To achieve this, this commit adds the `ruleset_id` and `ruleset_source_type` fields to the RepositoryRule object according to the returned information from the github API.
tomfeigin
force-pushed
the
add-ruleset-id-to-repository-rule-object
branch
from
232db8b to
b5fda6d
Compare
gmlewis
approved these changes
Mar 3, 2024
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @tomfeigin !
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this commit is to allow further querying of rulesets for a specific branch, at the organization or the repository level.
To achieve this, this commit adds the
ruleset_idandruleset_source_typefields to the RepositoryRule object according to the returned information from the github API.