Skip to content

Add t.Parallel to unit tests#3297

Merged
gmlewis merged 3 commits intogoogle:masterfrom
gmlewis:parallel-tests
Oct 5, 2024
Merged

Add t.Parallel to unit tests#3297
gmlewis merged 3 commits intogoogle:masterfrom
gmlewis:parallel-tests

Conversation

@gmlewis
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis commented Oct 1, 2024

On my system, this cuts testing time by approximately half.

Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 1, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (2b8c7fa) to head (2a5e218).
Report is 135 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
- Coverage   97.72%   93.05%   -4.67%     
==========================================
  Files         153      172      +19     
  Lines       13390    11772    -1618     
==========================================
- Hits        13085    10955    -2130     
- Misses        215      723     +508     
- Partials       90       94       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmlewis
Copy link
Copy Markdown
Collaborator Author

gmlewis commented Oct 3, 2024

@alexandear - might you have time to review this PR, please?

Comment thread github/actions_artifacts_test.go
Comment thread github/actions_cache_test.go
Comment thread test/integration/activity_test.go
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis requested a review from alexandear October 4, 2024 16:23
Copy link
Copy Markdown
Contributor

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tools/metadata/main_test.go Outdated
@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 5, 2024
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@gmlewis gmlewis merged commit dc884c2 into google:master Oct 5, 2024
@gmlewis gmlewis deleted the parallel-tests branch October 5, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants