Add BranchProtectionConfigurationEvent and SecretScanningAlertLocationEvent

[maditya]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (2b8c7fa) to head (3073929).
Report is 160 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3332      +/-   ##
==========================================
- Coverage   97.72%   93.01%   -4.71%     
==========================================
  Files         153      172      +19     
  Lines       13390    14848    +1458     
==========================================
+ Hits        13085    13811     +726     
- Misses        215      944     +729     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gmlewis]

Thank you, @maditya.
To add new events, we need to make some more changes to the following files:

• event_types_test.go
• messages.go
• messages_test.go

Please see #3258 for an example of the changes that are needed.
Thanks again!

[gmlewis]

Please fix the unit tests locally by running the commands in step 4 in CONTRIBUTING.md and then push (not force-push) the changes to this PR.

[maditya]

--- FAIL: TestProjectsService_DeleteProjectCard (0.00s)
    projects_test.go:611: Projects.DeleteProjectCard returned error: Delete "http://127.0.0.1:39961/api-v3/projects/columns/cards/1": net/http: HTTP/1.x transport connection broken: http: CloseIdleConnections called

@gmlewis this seems like an intermittent failure unrelated to the changes in this PR. Unable to reproduce it locally. Can we re-run the workflow?

[gmlewis]

The changes to this file seem wrong to me.
I think you can revert the changes to this file.

[maditya]

This was a warning which I fixed.

Per https://pkg.go.dev/net/http

If WriteHeader is not called explicitly, the first call to Write
will trigger an implicit WriteHeader(http.StatusOK).

So I think we should either keep this change or explicitly call w.WriteHeader(http.StatusOK) before we write to w. Any thoughts?

[gmlewis]

Oh, interesting, so this is unrelated to this PR. OK. I'm fine to keep the change. Thanks.

[gmlewis]

Thank you, @maditya !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

[tomfeigin]

LGTM

[gmlewis]

Thank you, @tomfeigin !
Merging.