Add support for fetching artifact attestations at the org, repo and user level#3334
Merged
gmlewis merged 13 commits intogoogle:masterfrom Oct 27, 2024
gillisandrew:feat-attestations
Merged
Add support for fetching artifact attestations at the org, repo and user level#3334gmlewis merged 13 commits intogoogle:masterfrom gillisandrew:feat-attestations
gmlewis merged 13 commits intogoogle:masterfrom
gillisandrew:feat-attestations
Conversation
gmlewis
changed the title
gmlewis
requested changes
Oct 24, 2024
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @gillisandrew!
A few questions and tweaks, please.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3334 +/- ##
==========================================
- Coverage 97.72% 92.29% -5.43%
==========================================
Files 153 176 +23
Lines 13390 15019 +1629
==========================================
+ Hits 13085 13862 +777
- Misses 215 1064 +849
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
requested changes
Oct 25, 2024
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @gillisandrew .
Please add unit tests for the newly-added methods.
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
reviewed
Oct 25, 2024
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
gmlewis
approved these changes
Oct 25, 2024
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @gillisandrew !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
Contributor
Author
|
@gmlewis Great! Thanks for your help and feedback, really appreciate it. |
Collaborator
|
Thank you, @tomfeigin ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub artifact attestations is now generally available
This pull request adds support for listing attestations hosted on GitHub for a given subject digest. Those attestations can then be verified using another library such as sigstore-go. I've included a basic demo as an example.