feat(secret scanning): Support pull_request_comment_url#3344
feat(secret scanning): Support pull_request_comment_url#3344gmlewis merged 1 commit intogoogle:masterfrom
pull_request_comment_url#3344Conversation
Modify `SecretScanningAlertLocationDetails` to recognize API responses of type `pull_request_comment_url`.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
If someone is able to re-run the |
pull_request_comment_urlpull_request_comment_url
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3344 +/- ##
==========================================
- Coverage 97.72% 92.30% -5.42%
==========================================
Files 153 176 +23
Lines 13390 15031 +1641
==========================================
+ Hits 13085 13874 +789
- Misses 215 1064 +849
- Partials 90 93 +3 ☔ View full report in Codecov by Sentry. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @chrisallenlane !
LGTM.
Merging.
Modify
SecretScanningAlertLocationDetailsto recognize API responses of typepull_request_comment_url.Per the documentation available here:
https://docs.github.com/en/rest/secret-scanning/secret-scanning?apiVersion=2022-11-28
For requests to this route:
The API may return JSON that matches the following shape:
(I'm sorry I can't provide a more specific link. The docs don't make one available.)
Previously,
go-githubwould not expose that data to the user. This change makes it available by adding a new field (PullRequestCommentURL) to theSecretScanningAlertLocationDetailsstruct.Tests are included.