Skip to content

Update security manager operations to use organization roles REST APIs#3418

Closed
just-joshing wants to merge 7 commits intogoogle:masterfrom
just-joshing:master
Closed

Update security manager operations to use organization roles REST APIs#3418
just-joshing wants to merge 7 commits intogoogle:masterfrom
just-joshing:master

Conversation

@just-joshing
Copy link
Copy Markdown
Contributor

The organization security manager role REST APIs are being sunset (https://gh.io/security-managers-rest-api-sunset) in favor of the organization roles REST APIs.

Instead of introducing a breaking change by removing the operations from go-github, this PR updates the operations to use the organization roles REST APIs so consumers (such as Terraform) can continue to manage organization security manager teams without needing to change code.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jan 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 92.19%. Comparing base (2b8c7fa) to head (fc83925).
Report is 212 commits behind head on master.

Files with missing lines Patch % Lines
github/orgs_security_managers.go 82.14% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3418      +/-   ##
==========================================
- Coverage   97.72%   92.19%   -5.53%     
==========================================
  Files         153      173      +20     
  Lines       13390    14949    +1559     
==========================================
+ Hits        13085    13782     +697     
- Misses        215     1072     +857     
- Partials       90       95       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-joshing just-joshing reopened this Jan 6, 2025
@just-joshing just-joshing marked this pull request as ready for review January 6, 2025 21:19
@just-joshing
Copy link
Copy Markdown
Contributor Author

#3421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant