Skip to content

chore: Fix otel module name#4187

Merged
gmlewis merged 2 commits intogoogle:masterfrom
alexandear-org:chore/fix-otel-module-name
May 4, 2026
Merged

chore: Fix otel module name#4187
gmlewis merged 2 commits intogoogle:masterfrom
alexandear-org:chore/fix-otel-module-name

Conversation

@alexandear
Copy link
Copy Markdown
Contributor

@alexandear alexandear commented May 1, 2026

Fixes: #4185
Closes: #4186

I think the issue is the otel module name: it should be github.com/google/go-github/otel/v85, not github.com/google/go-github/v85/otel.

See modules and tags in https://github.com/thepudds/nested-module-example

@gmlewis
Copy link
Copy Markdown
Collaborator

gmlewis commented May 1, 2026

Then maybe we don't need the go.work?
I would love to NOT add that file.

Comment thread example/go.mod Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.71%. Comparing base (0a16e22) to head (f2ad552).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4187      +/-   ##
==========================================
+ Coverage   93.69%   93.71%   +0.01%     
==========================================
  Files         210      209       -1     
  Lines       19763    19770       +7     
==========================================
+ Hits        18517    18527      +10     
+ Misses       1049     1046       -3     
  Partials      197      197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexandear
Copy link
Copy Markdown
Contributor Author

Then maybe we don't need the go.work? I would love to NOT add that file.

Yes. I think we don't need to add the go.work.

Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you, @alexandear!
LGTM.
Merging.

@gmlewis gmlewis merged commit 6c643b8 into google:master May 4, 2026
8 checks passed
@alexandear alexandear deleted the chore/fix-otel-module-name branch May 4, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't import the otel package

2 participants