Conversation
dmitshur
force-pushed
the
remove-deprecated-apis
branch
from
66f3140 to
dae2143
Compare
Member
Author
This is a breaking API change. However, it removes things that were deprecated and shouldn't be used anymore (including something that's available in standard library). Next commit will be a large breaking API change anyway, so it makes more sense to get rid of the deprecated things instead of updating their API. http.StatusUnprocessableEntity was added in Go 1.7, and so we can use it instead of own equivalent constant. Anyone who was previously using it should switch to using http.StatusUnprocessableEntity as well. Consider this commit to deprecate StatusUnprocessableEntity and remove it in one. Helps #526.
dmitshur
force-pushed
the
remove-deprecated-apis
branch
from
dae2143 to
f34b33d
Compare
Member
Author
|
(Side note, I had to rebase this on latest master to resolve conflicts, because the commit message of the previous commit changed (added PR number to the title). The actual contents of the commit haven't changed.) |
dmitshur
added a commit
that referenced
this pull request
Feb 18, 2017
bubg-dev
pushed a commit
to bubg-dev/go-github
that referenced
this pull request
Jun 16, 2017
This is a breaking API change. However, it removes things that were deprecated and shouldn't be used anymore (including something that's available in standard library). Next commit will be a large breaking API change anyway (which we need to do in order to resolve google#526 in a reasonable way), so it makes more sense to get rid of the deprecated things instead of updating their API. http.StatusUnprocessableEntity was added in Go 1.7, and so we can use it instead of own equivalent constant. Anyone who was previously using it should switch to using http.StatusUnprocessableEntity as well. Consider this commit to deprecate StatusUnprocessableEntity and remove it in one. Helps google#526.
bubg-dev
pushed a commit
to bubg-dev/go-github
that referenced
this pull request
Jun 16, 2017
This is a followup to google#555. mostRecent was created specifically to support Rate method in google#347. That method is now gone (removed in google#555), so mostRecent is unused and can be safely removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: Please note the base of this PR is currently the
require-go17-plusbranch rather thanmaster. This PR is for review purposes only. Once #554 is merged, I will change base of this PR tomasterand it can be mergeable then.This is part 2 of 3 PRs to resolve #526 (as was suggested to split PR #529 in #529 (comment)).
Please see commit message for change details:
As I wrote in #529 (comment):