Skip to content

Fix compatibility with setuptools 72 #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnbartholomew merged 1 commit into from
Mar 12, 2025
Merged

Fix compatibility with setuptools 72 #763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from setuptools import setup
from setuptools import Extension
from setuptools.command.build_ext import build_ext as BuildExt
from setuptools.command.test import test as TestCommand
from subprocess import Popen, PIPE

DIR = os.path.abspath(os.path.dirname(__file__))
Expand Down Expand Up @@ -52,14 +51,6 @@ def run(self):

BuildExt.run(self)


class NoopTestCommand(TestCommand):
def __init__(self, dist):
print(
"_gojsonnet does not support running tests with 'python setup.py test'. Please run 'pytest'."
)


jsonnet_ext = Extension(
"_gojsonnet",
sources=MODULE_SOURCES,
Expand All @@ -79,7 +70,6 @@ def __init__(self, dist):
version=get_version(),
cmdclass={
"build_ext": BuildJsonnetExt,
"test": NoopTestCommand,
},
ext_modules=[jsonnet_ext],
)