Skip to content
This repository was archived by the owner on Oct 27, 2022. It is now read-only.

Support Python3 syntax#17

Open
adithyagokhale wants to merge 1 commit intogoogle:masterfrom
adithyagokhale:master
Open

Support Python3 syntax#17
adithyagokhale wants to merge 1 commit intogoogle:masterfrom
adithyagokhale:master

Conversation

@adithyagokhale
Copy link

I was migrating few modules to python3 in my project and noticed that apputils are still not compliant with python3 syntax. With these changes I was able to proceed with the migration.

I was migrating few modules to python3 in my project and noticed that apputils are still not compliant with python3 syntax. With these chages I was able to proceed with the migration.
@google-cla
Copy link

google-cla bot commented Sep 17, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@adithyagokhale
Copy link
Author

@googlebot I signed it!

@gpshead
Copy link

gpshead commented Sep 21, 2020

Do the things found using apputils use any APIs that would prevent them from migrating to the supported replacement for apputils and gflags known as https://pypi.org/project/absl-py/?

argv = FLAGS(args)
return argv
except flags.FlagsError, error:
except (flags.FlagsError, error):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These except transformations are incorrect. The old except , syntax should become except flags.FlagsError as error:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants