Conversation
I was migrating few modules to python3 in my project and noticed that apputils are still not compliant with python3 syntax. With these chages I was able to proceed with the migration.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
Do the things found using apputils use any APIs that would prevent them from migrating to the supported replacement for apputils and gflags known as https://pypi.org/project/absl-py/? |
| argv = FLAGS(args) | ||
| return argv | ||
| except flags.FlagsError, error: | ||
| except (flags.FlagsError, error): |
There was a problem hiding this comment.
These except transformations are incorrect. The old except , syntax should become except flags.FlagsError as error:
I was migrating few modules to python3 in my project and noticed that apputils are still not compliant with python3 syntax. With these changes I was able to proceed with the migration.