Don't rely on Android desugaring. #2966
Merged
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Google libraries that rely on Gson require Android 23 *without* desugaring, because otherwise their clients would be forced to enable desugaring too. So revert to the standard animal-sniffer configuration, and reinstate the local `toIntExact` implementation.
cpovirk
approved these changes
Dec 24, 2025
Member
cpovirk
left a comment
cpovirk
left a comment
There was a problem hiding this comment.
I suspect that the tests are wrong, as I don't believe there's any way to build an Android app that doesn't support toIntExact nowadays, since that's covered by a separate system ("backporting?") that is separate from opt-in desugaring. But making the tests correct is likely shockingly difficult, so I see no need to fight them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Google libraries that rely on Gson require Android 23 without desugaring, because otherwise their clients would be forced to enable desugaring too. So revert to the standard animal-sniffer configuration, and reinstate the local
toIntExactimplementation.Also, catch
LinkageErrorin addition toReflectiveOperationExceptionwhen trying to load the newJavaTimeTypeAdaptersclass.