Address https://errorprone.info/bugpattern/UnnecessaryParentheses warnings in tests.#7771
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 9, 2025
Merged
Conversation
…nings in tests. A couple notes on the `primitives` changes: - I realized that we might as well use `Double.hashCode(double)` and `Float.hashCode(float)` there instead of boxing and calling the instance `hashCode()` method. (I'm going to change the _prod_ code in another CL.) - We probably don't even need to make sure that the expected values in our assertions have the exact right runtime type, given that Truth considers, e.g., the `Integer` value `1` to be equal to the `Long` value `1L`. I still kept the types matching when it was easy to do (e.g., `1.0`, `1.0f`), but I didn't bother when it requires a cast (`(short) 1`). PiperOrigin-RevId: 745662180
copybara-service
Bot
force-pushed
the
test_745579695
branch
from
3f5f1df to
795051e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address https://errorprone.info/bugpattern/UnnecessaryParentheses warnings in tests.
A couple notes on the
primitiveschanges:Double.hashCode(double)andFloat.hashCode(float)there instead of boxing and calling the instancehashCode()method. (I'm going to change the prod code in another CL.)Integervalue1to be equal to theLongvalue1L. I still kept the types matching when it was easy to do (e.g.,1.0,1.0f), but I didn't bother when it requires a cast ((short) 1).