Apply OCI seccomp filters to exec processes#12692
Open
dany74q wants to merge 2 commits intogoogle:masterfrom
Open
Apply OCI seccomp filters to exec processes#12692dany74q wants to merge 2 commits intogoogle:masterfrom
dany74q wants to merge 2 commits intogoogle:masterfrom
Conversation
dany74q
force-pushed
the
exec-seccomp-filters
branch
from
f4b3e64 to
833db7f
Compare
dany74q
force-pushed
the
exec-seccomp-filters
branch
from
833db7f to
f93c612
Compare
EtiennePerot
reviewed
Mar 9, 2026
Collaborator
EtiennePerot
left a comment
EtiennePerot
left a comment
There was a problem hiding this comment.
Can you add a unit test for this in runsc/container/multi_container_test.go? It should verify that the correct seccomp filter is applied for multi-container cases. Set different seccomp rules in different containers (e.g. specific syscalls being denied with SCMP_ACT_ERRNO), then exec programs in each container that verifies that the syscalls they should otherwise have permission to call gets an error code, while syscalls they should be able to call can actually be called.
dany74q
force-pushed
the
exec-seccomp-filters
branch
from
f93c612 to
5270baa
Compare
Seccomp filters ae currently only installed during `runsc run` but not in `runsc exec`. This commit adds the ability to pass a seccomp program on ExecArgs to apply them for executable processes as well.
dany74q
force-pushed
the
exec-seccomp-filters
branch
from
5270baa to
e6d64fd
Compare
EtiennePerot
approved these changes
Mar 10, 2026
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Seccomp filters ae currently only installed during `runsc run` but not in `runsc exec`. This commit adds the ability to pass a seccomp program on ExecArgs to apply them for executable processes as well. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12692 from dany74q:exec-seccomp-filters e6d64fd PiperOrigin-RevId: 881472183
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Seccomp filters ae currently only installed during `runsc run` but not in `runsc exec`. This commit adds the ability to pass a seccomp program on ExecArgs to apply them for executable processes as well. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12692 from dany74q:exec-seccomp-filters e6d64fd PiperOrigin-RevId: 881472183
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Seccomp filters ae currently only installed during `runsc run` but not in `runsc exec`. This commit adds the ability to pass a seccomp program on ExecArgs to apply them for executable processes as well. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12692 from dany74q:exec-seccomp-filters e6d64fd PiperOrigin-RevId: 881472183
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Seccomp filters ae currently only installed during `runsc run` but not in `runsc exec`. This commit adds the ability to pass a seccomp program on ExecArgs to apply them for executable processes as well. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12692 from dany74q:exec-seccomp-filters e6d64fd PiperOrigin-RevId: 881472183
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
Seccomp filters ae currently only installed during `runsc run` but not in `runsc exec`. This commit adds the ability to pass a seccomp program on ExecArgs to apply them for executable processes as well. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12692 from dany74q:exec-seccomp-filters e6d64fd PiperOrigin-RevId: 881472183
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
Seccomp filters ae currently only installed during `runsc run` but not in `runsc exec`. This commit adds the ability to pass a seccomp program on ExecArgs to apply them for executable processes as well. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12692 from dany74q:exec-seccomp-filters e6d64fd PiperOrigin-RevId: 881472183
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 11, 2026
Seccomp filters ae currently only installed during `runsc run` but not in `runsc exec`. This commit adds the ability to pass a seccomp program on ExecArgs to apply them for executable processes as well. FUTURE_COPYBARA_INTEGRATE_REVIEW=#12692 from dany74q:exec-seccomp-filters e6d64fd PiperOrigin-RevId: 881472183
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seccomp filters ae currently only installed during
runsc runbut not inrunsc exec.This commit adds the ability to pass a seccomp program on ExecArgs to apply them for executable processes as well.