feat(DeadCodeElimination - While loop and Function wrapper): Add WhileStatementElimination and UnusedFunctionElimination in DCE pass #39
Conversation
Introduces a new WhileStatementElimination pass to the Dead Code Elimination framework. This pass identifies 'while' loops with a constantly false condition and removes them entirely. Also includes minor header reordering and adjusts pointer syntax for consistency within 'pass.cc'.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
shanjiang98
changed the title
| "input.js", | ||
| "output.generated.txt", | ||
| "//maldoca/js/ir:lit_test_files", | ||
| "//third_party/maldoca/js/ir:lit_test_files", |
There was a problem hiding this comment.
We should drop the third_party part, since that is an internal path.
| @@ -0,0 +1,1489 @@ | |||
| // exec:begin | |||
There was a problem hiding this comment.
Add a test case that just runs DCE, i.e. the input should be the state after dynamic constant propagation.
|
|
||
| while(true){ | ||
| console.log("Should not be eliminated"); | ||
| } No newline at end of file |
There was a problem hiding this comment.
You can add an empty line at the end to get rid of this warning.
| @@ -0,0 +1,7 @@ | |||
| while(false){ | |||
There was a problem hiding this comment.
Let's format this (maybe you have to do it manually).
| namespace maldoca { | ||
| void IfStatementElimination(mlir::Operation* root_op) { | ||
| root_op->walk([&](JshirIfStatementOp op) { | ||
| namespace maldoca |
There was a problem hiding this comment.
Could you try putting a clang-format config in the repo?
I found this: https://github.com/kehanXue/google-style-clang-format
| mlir::Region &test_region = op.getTest(); | ||
| if (test_region.empty()) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| auto expr_region_end_op = | ||
| llvm::dyn_cast<JsirExprRegionEndOp>(&test_region.front().back()); | ||
| if (expr_region_end_op == nullptr) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| auto condition_op = | ||
| expr_region_end_op.getOperand().getDefiningOp<JsirBooleanLiteralOp>(); | ||
| if (condition_op == nullptr) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
GetExprRegionOp<JsirBooleanLiteralOp>(op.getTest())
| }); | ||
| } | ||
|
|
||
| struct SymbolInfo |
There was a problem hiding this comment.
Add comments that at least explain what inner and outer mean.
| if (llvm::isa<JsirExprsRegionEndOp>(op) || llvm::isa<JsirExprRegionEndOp>(op) ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
// TODO: We can remove this special handling once the trivia is fixed.
| LOG(INFO) << "Warning: Symbol has references but no definitions: " | ||
| << symbol.name() << std::endl; |
There was a problem hiding this comment.
We should remove this log if this is not an error, otherwise it might spam the log.
| } | ||
| if (info.definitions.size() > 1) | ||
| { | ||
| LOG(INFO) << "Warning: Multiple definitions for symbol: " |
There was a problem hiding this comment.
Can you remind us why this happens?
2 participants
Introduces a new WhileStatementElimination pass to the Dead Code Elimination framework. This pass identifies 'while' loops with a constantly false condition and removes them entirely.