Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Fixes (!?) init container command#1190

Closed
DazWilkin wants to merge 1 commit intogoogle:masterfrom
DazWilkin:DazWilkin-docker-compose
Closed

Fixes (!?) init container command#1190
DazWilkin wants to merge 1 commit intogoogle:masterfrom
DazWilkin:DazWilkin-docker-compose

Conversation

@DazWilkin
Copy link
Contributor

The curl command embedded within the init container was failing for docker-compose.

It's companion Kubernetes Pod, works.

By correcting the command (YAML) syntax and aligning this with the Kubernetes Pod definition, it appears to now work correctly:

It creates the default directory.

The `curl` command embedded within the `init` container was failing for `docker-compose`.

It's companion Kubernetes Pod, works.

By correcting the `command` (YAML) syntax and aligning this with the Kubernetes Pod definition, it appears to now work correctly:

It creates the 'default' directory.
@DazWilkin DazWilkin requested a review from gdbelvin as a code owner February 6, 2019 21:33
@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #1190 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
- Coverage   65.13%   64.86%   -0.27%     
==========================================
  Files          46       46              
  Lines        3336     3336              
==========================================
- Hits         2173     2164       -9     
- Misses        808      813       +5     
- Partials      355      359       +4
Impacted Files Coverage Δ
core/sequencer/trillian_client.go 59.18% <0%> (-4.09%) ⬇️
core/sequencer/server.go 72.89% <0%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c321c...ca21060. Read the comment docs.

@DazWilkin DazWilkin closed this Feb 8, 2019
@DazWilkin DazWilkin deleted the DazWilkin-docker-compose branch February 8, 2019 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant