This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Conversation
AlCutter
reviewed
Jul 18, 2019
| @@ -1,9 +1,13 @@ | |||
| FROM golang:1.12 as build | |||
|
|
|||
| WORKDIR /go/src/github.com/google/keytransparency | |||
Member
There was a problem hiding this comment.
Would be neat if these all shared the same build stage, is that possible?
Contributor
Author
There was a problem hiding this comment.
Or what would be the value in doing that?
Member
There was a problem hiding this comment.
I was thinking that if there were something like:
FROM ... as base
...
go mod download
COPY ...
which was then shared by all the job-specific Dockerfiles, e.g.:
FROM base as build:
go get .../${thing}
FROM distroless/...
COPY --from=build ...
Then you'd save having to rebuild the same base image/re-fetching the same modules etc. repeatedly.
Codecov Report
@@ Coverage Diff @@
## master #1325 +/- ##
==========================================
+ Coverage 30.26% 30.29% +0.02%
==========================================
Files 48 48
Lines 3869 3869
==========================================
+ Hits 1171 1172 +1
+ Misses 2517 2516 -1
Partials 181 181
Continue to review full report at Codecov.
|
RJPercival
approved these changes
Jul 18, 2019
* master: Extract log tracking into separate package (google#1317)
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 18, 2019
* master: Cache go mod download (google#1325) Extract log tracking into separate package (google#1317)
gdbelvin
added a commit
to gdbelvin/keytransparency
that referenced
this pull request
Jul 18, 2019
* master: Cache go mod download (google#1325) Extract log tracking into separate package (google#1317)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.