This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Merged
Conversation
The last use of object hash was used to pin the config in the gobindclient. Rather than hashing the config, future versions of the client should either build in a static config, or supply it direclty
Codecov Report
@@ Coverage Diff @@
## master #1441 +/- ##
=======================================
Coverage 66.31% 66.31%
=======================================
Files 54 54
Lines 4026 4026
=======================================
Hits 2670 2670
Misses 962 962
Partials 394 394Continue to review full report at Codecov.
|
mhutchinson
approved these changes
Jan 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last use of object hash was used to pin the config in the
gobindclient. Rather than hashing the config, future versions of the
client should either build in a static config, or supply it direclty