Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Portable docker images cleanup script#1445

Merged
gdbelvin merged 1 commit intogoogle:masterfrom
gdbelvin:cleanup
Feb 5, 2020
Merged

Portable docker images cleanup script#1445
gdbelvin merged 1 commit intogoogle:masterfrom
gdbelvin:cleanup

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Feb 3, 2020

Support running the cleanup script on both mac and linux.
gnudate on mac is gdate, while it is date on linux.

Also separate the cleanup script so deployments can be run in smaller steps.

Support running the cleanup script on both mac and linux.
gnudate on mac is `gdate`, while it is `date` on linux.

Also separate the cleanup script so deployments can be run piecemeal
@gdbelvin gdbelvin requested a review from a team as a code owner February 3, 2020 16:48
@gdbelvin gdbelvin requested a review from taknira February 3, 2020 16:48
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #1445 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1445     +/-   ##
=========================================
- Coverage   66.49%   66.39%   -0.1%     
=========================================
  Files          54       54             
  Lines        4026     4026             
=========================================
- Hits         2677     2673      -4     
- Misses        958      960      +2     
- Partials      391      393      +2
Impacted Files Coverage Δ
core/sequencer/trillian_client.go 58.57% <0%> (-2.86%) ⬇️
core/sequencer/server.go 73.94% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50329f2...f53709a. Read the comment docs.

@gdbelvin gdbelvin merged commit ab27b74 into google:master Feb 5, 2020
@gdbelvin gdbelvin deleted the cleanup branch February 5, 2020 14:18
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Feb 5, 2020
* master:
  Portable docker images cleanup script (google#1445)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants