This repository was archived by the owner on Oct 11, 2024. It is now read-only.
Merged
Conversation
golangcibot
reviewed
Feb 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #1453 +/- ##
==========================================
+ Coverage 66.59% 67.95% +1.36%
==========================================
Files 54 54
Lines 4026 4026
==========================================
+ Hits 2681 2736 +55
+ Misses 956 890 -66
- Partials 389 400 +11
Continue to review full report at Codecov.
|
The previous NoopElection broke the API contract of the election factory because it did not cancel contexts upon resigning. As a result, the KT sequencer hung attempting to resign mastership. This PR introduces a new `forcemaster.Election` which respects the election API, and tests it against the `election.Tracker`.
Contributor
Author
|
ForceMaster is for deployments that don't have etcd for mastership
…On Thu, Feb 13, 2020 at 5:35 PM Tatiana Merkulova ***@***.***> wrote:
***@***.**** approved this pull request.
Why ForceMaster?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1453?email_source=notifications&email_token=AABQOTXL7TEFUNRU6W37673RCWAF7A5CNFSM4KUWUM52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVOP4HI#pullrequestreview-358415901>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABQOTR7DEIHAMR4YRJTP3TRCWAF7ANCNFSM4KUWUM5Q>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous NoopElection broke the API contract of the election factory
because it did not cancel contexts upon resigning. As a result, the KT
sequencer hung attempting to resign mastership.
This PR introduces a new
forcemaster.Electionwhich respects the electionAPI, and tests it against the
election.Tracker.