Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Comments

Refactor: Move kustomize set image to it's own script#1475

Merged
gdbelvin merged 2 commits intogoogle:masterfrom
gdbelvin:image_tag
Feb 26, 2020
Merged

Refactor: Move kustomize set image to it's own script#1475
gdbelvin merged 2 commits intogoogle:masterfrom
gdbelvin:image_tag

Conversation

@gdbelvin
Copy link
Contributor

This aids development by breaking the scripts into separate steps that can be run individually

This aids development by breaking the scripts into separate steps that can be run individually
@gdbelvin gdbelvin requested a review from a team as a code owner February 26, 2020 10:54
@gdbelvin gdbelvin requested a review from pphaneuf February 26, 2020 10:54
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #1475 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1475      +/-   ##
=========================================
- Coverage   68.05%   67.9%   -0.15%     
=========================================
  Files          54      54              
  Lines        4026    4026              
=========================================
- Hits         2740    2734       -6     
- Misses        884     891       +7     
+ Partials      402     401       -1
Impacted Files Coverage Δ
core/sequencer/election/tracker.go 70.11% <0%> (-10.35%) ⬇️
core/sequencer/server.go 73.94% <0%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 843f369...c001f13. Read the comment docs.

@pphaneuf pphaneuf removed their request for review February 26, 2020 15:20
Copy link

@Mercurrent Mercurrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's neat

@gdbelvin gdbelvin merged commit ba1c7e0 into google:master Feb 26, 2020
@gdbelvin gdbelvin deleted the image_tag branch February 26, 2020 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants