Wire in Logging and Metrics config maps to PullSubscription RA#219
Conversation
|
/retest |
| } | ||
|
|
||
| // Convert base64 encoded json logging.Config to logging.Config. | ||
| loggingConfig, err := resources.Base64ToLoggingConfig(startable.LoggingConfigBase64) |
There was a problem hiding this comment.
If somebody makes a logging error mistake, they will effectively kill all their pubsub messging. Maybe instead of panic log it with severity error. That way they can keep processing events, but without logging config changes taking effect?
There was a problem hiding this comment.
OK, I default if there is an error and if that still makes an error then I panic.
| // Convert base64 encoded json metrics.ExporterOptions to metrics.ExporterOptions. | ||
| metricsConfig, err := resources.Base64ToMetricsOptions(startable.MetricsConfigBase64) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
I disable metrics if an error now. No panic.
|
/lgtm |
|
The following is the coverage report on pkg/.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
/assign @vaikas-google