Skip to content
This repository was archived by the owner on Jun 19, 2022. It is now read-only.

Storage control plane metrics#246

Merged
knative-prow-robot merged 1 commit into
google:masterfrom
nachocano:storage_metrics
Sep 4, 2019
Merged

Storage control plane metrics#246
knative-prow-robot merged 1 commit into
google:masterfrom
nachocano:storage_metrics

Conversation

@nachocano
Copy link
Copy Markdown
Member

Helps with knative/eventing#1693

  • Adding control plane metrics for storage

@nachocano
Copy link
Copy Markdown
Member Author

/assign @n3wscott

@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @nachocano. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@n3wscott
Copy link
Copy Markdown
Contributor

n3wscott commented Sep 4, 2019

/lgtm
/approve
/ok-to-test

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, nachocano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants