Skip to content
This repository was archived by the owner on Jun 19, 2022. It is now read-only.

updated Status.ObservedGeneration for pullsubscription and storage#284

Merged
knative-prow-robot merged 1 commit into
google:masterfrom
capri-xiyue:issue_272
Sep 17, 2019
Merged

updated Status.ObservedGeneration for pullsubscription and storage#284
knative-prow-robot merged 1 commit into
google:masterfrom
capri-xiyue:issue_272

Conversation

@capri-xiyue
Copy link
Copy Markdown
Contributor

Fixes #272

Proposed Changes

  • Update status.ObservedGeneration for sources resources when sources resources get reconciled successfully
  • Added unit tests

Release Note

None

@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @capri-xiyue. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@capri-xiyue
Copy link
Copy Markdown
Contributor Author

/assign @Harwayne

@n3wscott
Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-metrics-robot
Copy link
Copy Markdown

The following is the coverage report on pkg/.
Say /test pull-google-knative-gcp-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pullsubscription/pullsubscription.go 66.7% 66.8% 0.2
pkg/reconciler/storage/storage.go 66.9% 67.1% 0.2

@n3wscott
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 3640a19 into google:master Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update status.ObservedGeneration for sources resources when sources resources get reconciled

5 participants