Perf testing for PubSub channel#312
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@n3wscott: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
| // Ok, ready to start pulling. | ||
| err := conn.Receive(ctx, func(ctx context.Context, m *pubsub.Message) { | ||
| logger.Info("got an event!") |
There was a problem hiding this comment.
Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line.
There was a problem hiding this comment.
Looks like this was fixed in cloudevents/sdk-go#189
|
cc @capri-xiyue |
|
Related to #310 |
3 participants
No description provided.