This repository was archived by the owner on Jun 19, 2022. It is now read-only.
Standardize True/False/Unknown status throughout knative-gcp#481
Merged
Conversation
yolocs
reviewed
Jan 14, 2020
Member
|
Sounds good!
…On Tue, Jan 14, 2020 at 2:36 PM capri-xiyue ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/apis/duck/v1alpha1/pubsub_lifecycle.go
<#481 (comment)>:
> @@ -20,23 +20,44 @@ import (
"knative.dev/pkg/apis"
)
-// MarkTopicNotReady sets the condition that the PubSub Topic is not ready and why.
-func (s *PubSubStatus) MarkTopicNotReady(cs *apis.ConditionSet, reason, messageFormat string, messageA ...interface{}) {
+// MarkTopicFalse sets the condition that the PubSub Topic is not ready and why.
+func (s *PubSubStatus) MarkTopicFalse(cs *apis.ConditionSet, reason, messageFormat string, messageA ...interface{}) {
I prefer MarkTopicFailed over MarkTopicNotReady since it's more clear. Is
that ok?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#481?email_source=notifications&email_token=ABD65DEDOVZJESAK3A4GZXLQ5Y5ANA5CNFSM4KGLHUY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRYAK6A#discussion_r366609658>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD65DHF7IP2GZHOW7Q6M73Q5Y5ANANCNFSM4KGLHUYQ>
.
|
Contributor
Author
|
@nachocano Could you help review this PR? |
nachocano
reviewed
Jan 15, 2020
nachocano
reviewed
Jan 15, 2020
nachocano
reviewed
Jan 15, 2020
nachocano
reviewed
Jan 15, 2020
nachocano
reviewed
Jan 15, 2020
nachocano
reviewed
Jan 15, 2020
nachocano
reviewed
Jan 15, 2020
nachocano
reviewed
Jan 16, 2020
nachocano
reviewed
Jan 16, 2020
nachocano
reviewed
Jan 16, 2020
nachocano
reviewed
Jan 16, 2020
nachocano
reviewed
Jan 16, 2020
nachocano
reviewed
Jan 16, 2020
nachocano
reviewed
Jan 16, 2020
nachocano
reviewed
Jan 16, 2020
nachocano
reviewed
Jan 16, 2020
Member
|
@capri-xiyue this looks great! Just a few nits if you can, and it should be ready to go... |
Member
|
/lgtm This looks great! Thanks @capri-xiyue |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: capri-xiyue, nachocano The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following is the coverage report on the affected files.
|
Contributor
Author
|
/retest |
1 similar comment
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #473
Proposed Changes
Release Note