Add SQL table for password resets#2751
Merged
gbrodman merged 1 commit intogoogle:masterfrom May 8, 2025
Merged
Conversation
We plan on using this for EPP password resets and registry lock password resets for now.
gbrodman
force-pushed
the
passwordResetSql
branch
from
e48ee1b to
672cb72
Compare
Collaborator
Author
|
@ptkach thoughts on this table as the backing storage for password reset requests? I was talking to Bruno and it looks like for both EPP and registry lock we want the request to come only from admin/tech, with the email being sent to the admin or the user in question respectively. |
Collaborator
Author
|
edit / update, we'll allow anyone with edit access to request an EPP password update |
Collaborator
Author
|
friendly ping @ptkach |
ptkach
approved these changes
May 8, 2025
Collaborator
ptkach
left a comment
ptkach
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
Collaborator
Sorry I thought I did LGTM this one |
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
We plan on using this for EPP password resets and registry lock password resets for now.
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
We plan on using this for EPP password resets and registry lock password resets for now.
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
We plan on using this for EPP password resets and registry lock password resets for now.
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
We plan on using this for EPP password resets and registry lock password resets for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We plan on using this for EPP password resets and registry lock password resets for now.
This change is