Don't always require contacts in CreateDomainCommand#2755
Merged
gbrodman merged 1 commit intogoogle:masterfrom May 15, 2025
Merged
Don't always require contacts in CreateDomainCommand#2755gbrodman merged 1 commit intogoogle:masterfrom
gbrodman merged 1 commit intogoogle:masterfrom
Conversation
If contacts are optional, they should be optional in the command too.
gbrodman
force-pushed
the
domainCommandContacts
branch
from
f5f5778 to
171a876
Compare
ptkach
approved these changes
May 15, 2025
Collaborator
ptkach
left a comment
ptkach
left a comment
There was a problem hiding this comment.
Makes sense
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gbrodman)
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
If contacts are optional, they should be optional in the command too.
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
If contacts are optional, they should be optional in the command too.
qrtp
pushed a commit
to unstoppabledomains/nomulus
that referenced
this pull request
Jun 27, 2025
If contacts are optional, they should be optional in the command too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If contacts are optional, they should be optional in the command too.
This change is