Skip optional parameters where the value is null in custom values#14
Skip optional parameters where the value is null in custom values#14noahdietz merged 1 commit intogoogle:masterfrom PaulWay:paulway_ignore_nulled_values_for_optional_params
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I've signed the CLA. |
|
CLAs look good, thanks! |
|
Thanks for the PR and apologies for the slow response. I'm cool with this implementation. Can you add a test to the Edit: |
|
Hi @PaulWay will you have a chance to add a test for this? This is helpful work, would love to include it 😃 |
|
Hi @noahdietz - sorry I haven't got to this; Javascript isn't my strong suit and I don't really understand the test suite. I've got a bit of something mangled together but I really don't know what I'm doing there. Would be happy to share it with you if you can help me get it working. |
Fix #13