bitcoin-core: Migrate to CMake#11516
Closed
hebasto wants to merge 1 commit into
Closed
Conversation
|
hebasto is a new contributor to projects/bitcoin-core. The PR must be approved by known contributors before it can be merged. The past contributors are: fanquake, guidovranken, dergoegge, maflcko, achow101 |
maflcko
reviewed
Jan 19, 2024
Contributor
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
CI won't run here, because you haven't contributed previously.
I think you can open a pull in your GitHub fork and enable GHA on the project, to avoid "spam" in this repo?
fanquake
reviewed
Jan 19, 2024
| # * --toolchain, see https://github.com/bitcoin/bitcoin/blob/master/depends/README.md | ||
| if [ "$SANITIZER" = "memory" ]; then | ||
| CONFIG_SITE="$PWD/depends/$BUILD_TRIPLET/share/config.site" ./configure --enable-fuzz SANITIZER_LDFLAGS="$LIB_FUZZING_ENGINE" --disable-hardening --with-asm=no | ||
| cmake -S .. -DCMAKE_C_COMPILER="$CC" -DCMAKE_CXX_COMPILER="$CXX" --toolchain depends/${BUILD_TRIPLET}/share/toolchain.cmake -DCMAKE_BUILD_TYPE=None -DFUZZ=ON -DSANITIZER_LDFLAGS="$LIB_FUZZING_ENGINE" -DHARDENING=OFF -DASM=OFF |
Contributor
There was a problem hiding this comment.
Shouldn't CC and CXX be coming from the toolchain file? Why do we need to (re-)set it explicitly here?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This testing PR was requested by reviewers of hebasto/bitcoin#43 and is not intended to be merged.