Conversation
0. Don't clone fuzz-introspector to /src since it breaks builds. 1. Install packages in python install script properly. Previously pip install atheris>=2.0.6 was interpreted as "redirect the output from pip install atheris" to the file "=2.0.6". 3. Clean up some miscellanious issues.
|
I assume this will break fuzz-introspector somewhere, but I'm not sure where. It should be easy to fix though and I don't think we need to block this PR on adjusting that code since FI isn't production code yet. |
DavidKorczynski
left a comment
DavidKorczynski
left a comment
There was a problem hiding this comment.
Am not sure if I missed something, but where is the change that causes fuzz-introspector not to cloned in /src (change num 0 you mention)? I can't spot the diff that causes this?
You're not missing anything. I am 🤦 I forgot to include it. |
ah cool! lgtm! |
|
Hmm...maybe I'll rewrite this to only include the introspector removal so we don't break anything. |
|
Thanks @jonathanmetzman ! Let's try this. |
* Clean up build infra issues. 0. Don't clone fuzz-introspector to /src since it breaks builds. 1. Install packages in python install script properly. Previously pip install atheris>=2.0.6 was interpreted as "redirect the output from pip install atheris" to the file "=2.0.6". 3. Clean up some miscellanious issues. * Include removal
* Clean up build infra issues. 0. Don't clone fuzz-introspector to /src since it breaks builds. 1. Install packages in python install script properly. Previously pip install atheris>=2.0.6 was interpreted as "redirect the output from pip install atheris" to the file "=2.0.6". 3. Clean up some miscellanious issues. * Include removal
4 participants
pip install atheris>=2.0.6 was interpreted as "redirect the output
from pip install atheris" to the file "=2.0.6".