perf(local): don't read the entire zip into memory #2445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a little suspect of the results I've produced, but it seems like this reduces memory usage by a decent amount e.g. with the Ubuntu SBOM used for #2217 we go from 1gb to 200mb total.
Ultimately, I think the theory is sound and that are not really any downsides so we might as well change this.
Note that this does not have any impact on scanning speed, just memory usage.